Skip to content

Feature: JSON-LD 추가 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Feature: JSON-LD 추가 #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06ff8c1
✨ feat: add JSON-LD
guesung Aug 8, 2024
d1d607e
Merge remote-tracking branch 'origin/develop' into feat/add-json-ld
guesung Aug 12, 2024
9e319a6
refactor: Analytics를 둘러싼 Suspense 제거
guesung Aug 12, 2024
a478e44
♻️ refactor : 컴포넌트 구조 컨벤션처럼
seondal Aug 12, 2024
054d253
Merge remote-tracking branch 'origin/develop' into feat/add-json-ld
guesung Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 src/components/Analytics/Analytics.tsx → src/app/Analytics.tsx
View file
Open in desktop
File renamed without changes.
15 changes: 15 additions & 0 deletions src/app/JsonLD.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import Script from 'next/script';

import { JSON_LD } from '@/constants';

export default function JsonLD() {
return (
<Script
id="faq-schema"
type="application/ld+json"
dangerouslySetInnerHTML={{
__html: JSON.stringify(JSON_LD),
}}
/>
);
}
14 changes: 6 additions & 8 deletions src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import './globals.css';

import { Suspense } from 'react';

import { Analytics } from '@/components/Analytics';
import Analytics from './Analytics';
import JsonLD from './JsonLD';
import { OverlayProvider } from '@/components/Overlay/OverlayProvider';
import METADATA from '@/constants/meta';
import QueryProvider from '@/provider/QueryProvider';
Expand All @@ -16,11 +15,10 @@ export const metadata: Metadata = METADATA;
export default function RootLayout({ children }: PropsWithChildren) {
return (
<html lang="ko">
<body className="flex justify-center w-screen touch-none bg-slate-100">
<div className="w-full overflow-scroll bg-white max-w-layout text-primary">
<Suspense>
<Analytics />
</Suspense>
<body className="flex w-screen touch-none justify-center bg-slate-100">
<div className="w-full max-w-layout overflow-scroll bg-white text-primary">
<Analytics />
<JsonLD />
<QueryProvider>
<RecoilProvider>
<OverlayProvider>{children}</OverlayProvider>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. JsonLD 컴포넌트를 가져오기 위해 새로운 import 문이 추가되었습니다. 이 코드 변경은 기능적인 면에서 안전합니다.

  2. RootLayout 함수 내에서 <JsonLD /> 컴포넌트가 Suspense 컴포넌트로 감싸여 있지 않습니다. 만약 JsonLD 컴포넌트가 데이터를 비동기적으로 로드한다면, Suspense로 감쌀 것을 고려해 볼 수 있습니다.

  3. 코드 리뷰에는 주로 더 많은 context나 페이지 전반의 처리 방식이 필요하지만, 해당 코드 조각 자체가 작아서 뚜렷한 문제점이 나타나지는 않습니다.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Suspense는 주로 비동기 작업(데이터 패칭, 지연 로딩 컴포넌트)을 처리하기 위해 사용합니다. JSON-LD스크립트는 정적 메타 데이터로, 비동기 로딩이 필요하지 않습니다.

또한, Suspense로 감싸면 서버에서 렌더링을 하지 않기 때문에 내부 컴포넌트의 렌더링에 있어서 지연이 발생해 SEO에 부정적인 영향을 미칠 수 있습니다.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드 패치는 대부분 좋아 보입니다. 개선 제안은 다음과 같습니다:

  1. Suspense 구성 요소에서 Error Boundary가 없으므로 코드에서 발생할 수 있는 오류를 처리하는 방법을 고려할 필요가 있습니다.
  2. JsonLD 컴포넌트의 위치는 Analytics 컴포넌트 다음에 배치되어 있지만, JsonLD 컴포넌트의 의존성 및 논리적 순서를 고려하여 올바른 위치에 배치되었는지 확인해야 합니다.

Expand Down
1 change: 0 additions & 1 deletion src/components/Analytics/index.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions src/components/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './JsonLD';
1 change: 1 addition & 0 deletions src/constants/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
export * from './meta';
export * from './auth';
export * from './error';
36 changes: 36 additions & 0 deletions src/constants/meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,39 @@ const METADATA: Metadata = {
};

export default METADATA;

export const JSON_LD = {
'@context': 'https://schema.org',
'@type': 'WebSite',
name: 'PosePicker | 포즈피커',
description: '포토부스에서 고민하는 당신을 위한 포즈 추천 서비스',
keywords: 'pose, photo booth, recommendation, 포즈, 포토부스, 추천',
url: 'https://www.posepicker.site',
image: 'https://www.posepicker.site/meta/og_main.png',
author: {
'@type': 'Organization',
name: 'PosePicker',
},
datePublished: '2024-08-08T00:00:00+09:00',
dateModified: '2024-08-08T00:00:00+09:00',
publisher: {
'@type': 'Organization',
name: 'PosePicker',
logo: {
'@type': 'ImageObject',
url: 'https://www.posepicker.site/pwa-icons/apple.png',
},
},
headline: '포즈가 고민될 땐? 포즈피커!',
mainEntityOfPage: {
'@type': 'WebPage',
'@id': 'https://www.posepicker.site',
},
offers: {
'@type': 'Offer',
price: '0',
priceCurrency: 'KRW',
availability: 'https://schema.org/InStock',
},
thumbnailUrl: 'https://www.posepicker.site/meta/og_main.png',
};