Skip to content

clean: make QuantizeSettings.CreateInstance parameter non nullable #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Apr 26, 2024

👋

It seems that this method is only invoked with non-null parameter.

internal static INativeInstance CreateInstance(IQuantizeSettings? instance)
{
if (instance is null)
return NativeInstance.Zero;
return QuantizeSettings.CreateNativeInstance(instance);
}

This PR remove nullable possibility of parameter.

Regards.

@dlemstra
Copy link
Owner

This is generated code and I am working on using source generators for this so there is no need to change this code.

@dlemstra dlemstra closed this Apr 26, 2024
@Gounlaf Gounlaf deleted the clean/quantize-settings-to-native-non-null branch April 29, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants