Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 11168: attributes for functions in core.stdc.time. #2372

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

radcapricorn
Copy link
Contributor

Preferably this needs to be looked at by @WalterBright. May break some third-party code. Phobos tests passed though.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @radcapricorn! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11168 normal core.stdc.time.asctime() is incorrectly marked as @trusted

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2372"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Nov 24, 2018
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for Walter's review.

@schveiguy
Copy link
Member

I re-triggered the build, not sure why the style check failed, I don't see any white space problems.

@thewilsonator
Copy link
Contributor

You can restart individual projects on build kite, please do so it'll be much faster.

@wilzbach
Copy link
Member

The style failure is unrelated.

@thewilsonator
Copy link
Contributor

For reference, so is dlang/ci.

@thewilsonator
Copy link
Contributor

Hmm, linux32 OOM'd @radcapricorn you'll need to give this a kick.

@wilzbach
Copy link
Member

The auto-tester will automatically restart itself...

@wilzbach
Copy link
Member

Besides if it passed before on the auto-tester on the same machine and that's the only failure and it's obviously unrelated, feel free to force merge (though do this with care).

@wilzbach wilzbach merged commit 377f048 into dlang:master Nov 29, 2018
@radcapricorn radcapricorn deleted the fix11168 branch November 29, 2018 10:38
@schveiguy
Copy link
Member

@thewilsonator I saw the rebuild button, I pushed it. Sorry ;)

@thewilsonator
Copy link
Contributor

NP, you know for next time ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants