-
-
Notifications
You must be signed in to change notification settings - Fork 417
Fix Issue 11168: attributes for functions in core.stdc.time. #2372
Conversation
Thanks for your pull request and interest in making D better, @radcapricorn! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2372" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait for Walter's review.
6de8a62
to
d25b1b2
Compare
I re-triggered the build, not sure why the style check failed, I don't see any white space problems. |
You can restart individual projects on build kite, please do so it'll be much faster. |
The style failure is unrelated. |
For reference, so is |
Hmm, linux32 OOM'd @radcapricorn you'll need to give this a kick. |
The auto-tester will automatically restart itself... |
Besides if it passed before on the auto-tester on the same machine and that's the only failure and it's obviously unrelated, feel free to force merge (though do this with care). |
@thewilsonator I saw the rebuild button, I pushed it. Sorry ;) |
NP, you know for next time ;) |
Preferably this needs to be looked at by @WalterBright. May break some third-party code. Phobos tests passed though.