-
-
Notifications
You must be signed in to change notification settings - Fork 650
ctfeexpr: support reinterpreting cast when switching safe/pure/nothrow in both directions #12514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctfeexpr: support reinterpreting cast when switching safe/pure/nothrow in both directions #12514
Conversation
allowing this cast breaks the type system |
Where's the bugreport which requests this? |
Yes. Although, AFAIK CTFE engine can handle these cases. Some functions on standard library use |
There's no bug report for this, atm. |
Please create a new one or add a changelog entry |
... both directions Signed-off-by: Luís Ferreira <contact@lsferreira.net>
caad5fa
to
3f12de0
Compare
Thanks for your pull request and interest in making D better, @ljmf00! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12514" |
Added a bugzilla reference and slightly extended the test case |
I'm so sorry for not answering quickly. As I mentioned previously here, dlang/dlang.org#2946 (comment), I'm very busy due to school stuff. |
No worries, I just wanted to have these changes to enable dlang/druntime#3494. |
Can we extend the same idea to other interpreting casts? |
I can look at this when I have some time. |
Signed-off-by: Luís Ferreira contact@lsferreira.net