Skip to content

const3.dd: start work on this one #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

const3.dd: start work on this one #2156

wants to merge 2 commits into from

Conversation

WalterBright
Copy link
Member

I moved the stuff about storage classes to the end, they really should be merged with https://dlang.org/spec/declaration.html#typequal_vs_storageclass

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

andralex
andralex previously requested changes Feb 1, 2018
View reviewed changes
spec/const3.dd Outdated
Each applies transitively to all subtypes.
$(P Type qualifiers modify a type by applying a $(I type constructor).
$(GLINK2 declaration, TypeCtor)s are:
$(D const), $(D immutable), $(D shared), and $(D inout).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many type constructors in D (see definition at https://en.wikipedia.org/wiki/Type_constructor): the array syntax T[], the pointer syntax T*, template instantiation A!T etc. are all type constructors.

These are qualifiers (and indeed they are also type constructors), and the types resulting from the application are called qualified types.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, I'll fix

@JinShil JinShil added the Vision https://wiki.dlang.org/Vision/2018H1 label Mar 23, 2018
@andralex
Copy link
Member

@WalterBright your changes overwrote my editorial changes, could you please check what your pushing process is? If you force push (with -f) into your branch, please change that to push without forcing. Then you'll get errors only if you need to pull first.

@andralex
Copy link
Member

For example I just created 5d7e597. Can you make sure it doesn't get overwritten. Thanks.

@WalterBright WalterBright dismissed andralex’s stale review June 10, 2018 07:17

applied the changes

@WalterBright WalterBright added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jul 4, 2018
@thewilsonator thewilsonator self-assigned this Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andralex andralex andralex left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@thewilsonator thewilsonator

Labels
72h no objection -> merge The PR will be merged if there are no objections raised. Needs Rebase stalled Vision https://wiki.dlang.org/Vision/2018H1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WalterBright @dlang-bot @andralex @JinShil @thewilsonator