Skip to content

Remove PermanentOwnable and ProxyBeacon as they have been deprecated due to OpenZeppelin upgrade. Adjust tests accordingly. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

joYyHack
Copy link
Contributor

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

Remove PermanentOwnable and ProxyBeacon as they have been deprecated due to OpenZeppelin upgrade. Adjust tests accordingly.

…due to OpenZeppelin upgrade. Adjust tests accordingly.
@joYyHack joYyHack requested a review from Arvolear March 11, 2025 19:00
@joYyHack joYyHack self-assigned this Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (2a16029) to head (a9879cb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   99.94%   99.94%   -0.01%     
==========================================
  Files          57       54       -3     
  Lines        3404     3383      -21     
  Branches      459      455       -4     
==========================================
- Hits         3402     3381      -21     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 1908eec into master Mar 12, 2025
@Arvolear Arvolear deleted the chore/clean-up branch March 12, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants