Solarity 3.0 #131

Arvolear · 2025-02-18T10:58:19Z

Migrating to OpenZeppelin 5.2.

* updated dependencies * specified initialOwner for __Ownable_init function * MathUpgradeable lib -> Math lib * created mock contract for ERC721Holder * updated test's error handlers to catch custom errors * fixed typo in test * Added custom TransparentUpgradeableProxy contract * Removed isContract() * Fixed typo * Cleaned up dependencies * Dropped tests for isContract() check in Diamond * Removed unnecessary dependency * Added solhint command to scripts * Renamed TransparentUpgradeableProxy to avoid collisions * Updated dependencies * Fixed package-lock * Switched to custom errors in contracts (#113) * Switched to custom errors in contracts * Review fixes: removed prefixes; removed redundant comments; refactored namings; added args to errors. * require -> revert in vectorMock * Remover unused imports * Review: removed zero args; added useful args. * Ordering errors in alphabetical order * Splited Traversal into separate file * review fixes; linting; errors are located at the top of file. * switched to own custom error instead of erc20 in DiamondERC20 * Explicitly marked visibility of state in mock contract * Fixed typo * Typo InvalidMaxDepth -> MaxDepthIsZero * switched to revertedWithCustomError in tests * Switched to custom error in RawReturnMock * Added testcase for _checkOnERC721Received. Coverage is 100% * Cleanup: ZERO_ADDR -> ZeroAddress from ethers; ordered imports in tests. * Specified import * Replaced ZERO_BYTES32 with ethers.ZeroHash * Replaced ZERO_ADDRESS with ethers.ZeroAddress * Updated .solhint config. Resolved solhint warnings --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com> * Added missed .withArgs() to error handlers * Updated .solhint config * Updated versions * updated openzeppelin to 5.1.0 * review fixes: linting * renamed TransparentProxy to AdminableProxy * moved IAdminableProxy to the interfaces; moved VerifierHelper out of snarkjs dir. * switched from staticcall to call through interface in AdminableProxyUpgrader * updated dev dependencies * downgraded types/chai and types/node * renamed transparent dir to adminable * placed Traversal lib into AvlTree file * erc721: - deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks; - added a new `_update` function for customizations * erc20: - deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks; - added a new `_update` function for customizations * linting * linting --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com>

* Crypto libs (#115) * added ecdsa384 lib * added rsassapss * try fix ci * fix callvalue * Added tests covering the `verify` and `_isOnCurve` functions * fix coverage * split getModifiedSigOrPubKey into modifyLeft and modifyRight * Added tests covering the RSASSAPSS lib * switched to assert two unreachable conditions * fixed typos in test * removed unused functions in U384 lib * added test for a U384.cmp function * trying to fix test for cmp * add brainpoolP384r1 test --------- Co-authored-by: aritkulova <aritkulova.yuliia@gmail.com> * updated crypto lib contracts: - pragma solidity; - solhint; - custom errors * updated missed pragma solidity * fixed typo in README --------- Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

- ecdsa256 contract (pragma solidity, solhint, custom errors); - package lock

codecov · 2025-02-21T17:23:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (6c2955d) to head (8b3a92c).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          56       57    +1     
  Lines        3380     3404   +24     
  Branches      386      459   +73     
=======================================
+ Hits         3378     3402   +24     
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contracts/libs/crypto/ECDSA512.sol

contracts/libs/data-structures/CartesianMerkleTree.sol

README.md

contracts/proxy/adminable/AdminableProxy.sol

hardhat.config.ts

scripts/utils/constants.ts

contracts/libs/zkp/VerifierHelper.sol

contracts/finance/staking/AStaking.sol

contracts/finance/staking/AValueDistributor.sol

contracts/diamond/utils/AInitializableStorage.sol

package.json

Arvolear

LFG!

aritkulova and others added 5 commits December 3, 2024 14:03

Updated pragma solidity to ^0.8.21 + renamed Abstract contracts (#116)

5fcf07e

updated:

9ee4854

- ecdsa256 contract (pragma solidity, solhint, custom errors); - package lock

resolve conflicts

04840f1