Updated OpenZeppelin to version 5.1.0 #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's use solhint more to help with style checking, etc |
KyrylR
reviewed
Jul 24, 2024
|
CI? |
|
Rename TransparentUpgradeableProxy to avoid collisions |
…into feat/update-to-openzeppelin-v5
* Switched to custom errors in contracts * Review fixes: removed prefixes; removed redundant comments; refactored namings; added args to errors. * require -> revert in vectorMock * Remover unused imports * Review: removed zero args; added useful args. * Ordering errors in alphabetical order * Splited Traversal into separate file * review fixes; linting; errors are located at the top of file. * switched to own custom error instead of erc20 in DiamondERC20 * Explicitly marked visibility of state in mock contract * Fixed typo * Typo InvalidMaxDepth -> MaxDepthIsZero * switched to revertedWithCustomError in tests * Switched to custom error in RawReturnMock * Added testcase for _checkOnERC721Received. Coverage is 100% * Cleanup: ZERO_ADDR -> ZeroAddress from ethers; ordered imports in tests. * Specified import * Replaced ZERO_BYTES32 with ethers.ZeroHash * Replaced ZERO_ADDRESS with ethers.ZeroAddress * Updated .solhint config. Resolved solhint warnings --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com>
Arvolear
reviewed
Nov 8, 2024
Arvolear
reviewed
Nov 8, 2024
Arvolear
reviewed
Nov 8, 2024
Arvolear
reviewed
Nov 8, 2024
Arvolear
reviewed
Nov 8, 2024
moved VerifierHelper out of snarkjs dir.
Arvolear
changed the title
Arvolear
reviewed
Nov 13, 2024
Arvolear
reviewed
Nov 13, 2024
Arvolear
reviewed
Nov 13, 2024
Arvolear
reviewed
Nov 13, 2024
Arvolear
reviewed
Nov 13, 2024
Arvolear
pushed a commit
that referenced
this pull request
Dec 3, 2024
* updated dependencies * specified initialOwner for __Ownable_init function * MathUpgradeable lib -> Math lib * created mock contract for ERC721Holder * updated test's error handlers to catch custom errors * fixed typo in test * Added custom TransparentUpgradeableProxy contract * Removed isContract() * Fixed typo * Cleaned up dependencies * Dropped tests for isContract() check in Diamond * Removed unnecessary dependency * Added solhint command to scripts * Renamed TransparentUpgradeableProxy to avoid collisions * Updated dependencies * Fixed package-lock * Switched to custom errors in contracts (#113) * Switched to custom errors in contracts * Review fixes: removed prefixes; removed redundant comments; refactored namings; added args to errors. * require -> revert in vectorMock * Remover unused imports * Review: removed zero args; added useful args. * Ordering errors in alphabetical order * Splited Traversal into separate file * review fixes; linting; errors are located at the top of file. * switched to own custom error instead of erc20 in DiamondERC20 * Explicitly marked visibility of state in mock contract * Fixed typo * Typo InvalidMaxDepth -> MaxDepthIsZero * switched to revertedWithCustomError in tests * Switched to custom error in RawReturnMock * Added testcase for _checkOnERC721Received. Coverage is 100% * Cleanup: ZERO_ADDR -> ZeroAddress from ethers; ordered imports in tests. * Specified import * Replaced ZERO_BYTES32 with ethers.ZeroHash * Replaced ZERO_ADDRESS with ethers.ZeroAddress * Updated .solhint config. Resolved solhint warnings --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com> * Added missed .withArgs() to error handlers * Updated .solhint config * Updated versions * updated openzeppelin to 5.1.0 * review fixes: linting * renamed TransparentProxy to AdminableProxy * moved IAdminableProxy to the interfaces; moved VerifierHelper out of snarkjs dir. * switched from staticcall to call through interface in AdminableProxyUpgrader * updated dev dependencies * downgraded types/chai and types/node * renamed transparent dir to adminable * placed Traversal lib into AvlTree file * erc721: - deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks; - added a new `_update` function for customizations * erc20: - deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks; - added a new `_update` function for customizations * linting * linting --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com>
Arvolear
added a commit
that referenced
this pull request
Feb 24, 2025
* Updated OpenZeppelin to version 5.1.0 (#109) * updated dependencies * specified initialOwner for __Ownable_init function * MathUpgradeable lib -> Math lib * created mock contract for ERC721Holder * updated test's error handlers to catch custom errors * fixed typo in test * Added custom TransparentUpgradeableProxy contract * Removed isContract() * Fixed typo * Cleaned up dependencies * Dropped tests for isContract() check in Diamond * Removed unnecessary dependency * Added solhint command to scripts * Renamed TransparentUpgradeableProxy to avoid collisions * Updated dependencies * Fixed package-lock * Switched to custom errors in contracts (#113) * Switched to custom errors in contracts * Review fixes: removed prefixes; removed redundant comments; refactored namings; added args to errors. * require -> revert in vectorMock * Remover unused imports * Review: removed zero args; added useful args. * Ordering errors in alphabetical order * Splited Traversal into separate file * review fixes; linting; errors are located at the top of file. * switched to own custom error instead of erc20 in DiamondERC20 * Explicitly marked visibility of state in mock contract * Fixed typo * Typo InvalidMaxDepth -> MaxDepthIsZero * switched to revertedWithCustomError in tests * Switched to custom error in RawReturnMock * Added testcase for _checkOnERC721Received. Coverage is 100% * Cleanup: ZERO_ADDR -> ZeroAddress from ethers; ordered imports in tests. * Specified import * Replaced ZERO_BYTES32 with ethers.ZeroHash * Replaced ZERO_ADDRESS with ethers.ZeroAddress * Updated .solhint config. Resolved solhint warnings --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com> * Added missed .withArgs() to error handlers * Updated .solhint config * Updated versions * updated openzeppelin to 5.1.0 * review fixes: linting * renamed TransparentProxy to AdminableProxy * moved IAdminableProxy to the interfaces; moved VerifierHelper out of snarkjs dir. * switched from staticcall to call through interface in AdminableProxyUpgrader * updated dev dependencies * downgraded types/chai and types/node * renamed transparent dir to adminable * placed Traversal lib into AvlTree file * erc721: - deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks; - added a new `_update` function for customizations * erc20: - deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks; - added a new `_update` function for customizations * linting * linting --------- Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com> * Updated pragma solidity to ^0.8.21 + renamed Abstract contracts (#116) * Updated crypto libs for v3.0.0 (#118) * Crypto libs (#115) * added ecdsa384 lib * added rsassapss * try fix ci * fix callvalue * Added tests covering the `verify` and `_isOnCurve` functions * fix coverage * split getModifiedSigOrPubKey into modifyLeft and modifyRight * Added tests covering the RSASSAPSS lib * switched to assert two unreachable conditions * fixed typos in test * removed unused functions in U384 lib * added test for a U384.cmp function * trying to fix test for cmp * add brainpoolP384r1 test --------- Co-authored-by: aritkulova <aritkulova.yuliia@gmail.com> * updated crypto lib contracts: - pragma solidity; - solhint; - custom errors * updated missed pragma solidity * fixed typo in README --------- Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com> * updated: - ecdsa256 contract (pragma solidity, solhint, custom errors); - package lock * refactor and add reinitializer * update readme --------- Co-authored-by: Yuliia Aritkulova <94910987+aritkulova@users.noreply.github.com> Co-authored-by: Kyryl Riabov <kyryl.ryabov@gmail.com> Co-authored-by: aritkulova <aritkulova.yuliia@gmail.com> Co-authored-by: mllwchrry <mariia.zhvanko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.