Skip to content

Switch repo to Django Commons #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tim-schilling
Copy link
Member

@tim-schilling tim-schilling commented Dec 10, 2024

Description

Related Issue

This is in preparation for django-commons/membership#131

Motivation and Context

See #1391

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

This is a WIP

@tim-schilling tim-schilling changed the title Switch to Django Common's code of conduct Switch repo to Django Commons Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (64cdeb4) to head (908e450).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   96.87%   96.95%   +0.08%     
==========================================
  Files          24       24              
  Lines        1470     1479       +9     
  Branches      240      189      -51     
==========================================
+ Hits         1424     1434      +10     
  Misses         25       25              
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Anders <6058745+ddabble@users.noreply.github.com>
@tim-schilling tim-schilling marked this pull request as ready for review March 15, 2025 12:29
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's get this merged :)

@tim-schilling I'm assuming that we should incorporate the changes of django-commons/best-practices@bed66ed, which was made after this PR was opened?

name: python-package-distributions
path: dist/
- name: Publish distribution 📦 to PyPI
uses: pypa/gh-action-pypi-publish@release/v1.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the release/ prefix to the version number - what's the function of that? Does it make any semantic difference? 🤔

We should probably also update to v1.12, which, to me, doesn't seem like it should require any other changes 🙂

Suggested change
uses: pypa/gh-action-pypi-publish@release/v1.10
uses: pypa/gh-action-pypi-publish@v1.12

The same goes for TestPyPI below.

on: push

env:
# Change these for your project's URLs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this can be removed :)

Suggested change
# Change these for your project's URLs

Copy link

codecov bot commented Jun 13, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants