-
Notifications
You must be signed in to change notification settings - Fork 491
Switch repo to Django Commons #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This uses the PyPI GitHub trusted publisher integration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 96.87% 96.95% +0.08%
==========================================
Files 24 24
Lines 1470 1479 +9
Branches 240 189 -51
==========================================
+ Hits 1424 1434 +10
Misses 25 25
+ Partials 21 20 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Anders <6058745+ddabble@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's get this merged :)
@tim-schilling I'm assuming that we should incorporate the changes of django-commons/best-practices@bed66ed, which was made after this PR was opened?
name: python-package-distributions | ||
path: dist/ | ||
- name: Publish distribution 📦 to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the release/
prefix to the version number - what's the function of that? Does it make any semantic difference? 🤔
We should probably also update to v1.12, which, to me, doesn't seem like it should require any other changes 🙂
uses: pypa/gh-action-pypi-publish@release/v1.10 | |
uses: pypa/gh-action-pypi-publish@v1.12 |
The same goes for TestPyPI below.
on: push | ||
|
||
env: | ||
# Change these for your project's URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this can be removed :)
# Change these for your project's URLs |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Description
Related Issue
This is in preparation for django-commons/membership#131
Motivation and Context
See #1391
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst
This is a WIP