-
Notifications
You must be signed in to change notification settings - Fork 7
fix: table icons of inline ckeditor respect dark mode #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideUpdated all table-related toolbar icons in the inline CKEditor to use fill="currentColor" instead of hardcoded colors so they automatically respect dark mode. ER Diagram: Updates to CKEditor Table Icon DefinitionserDiagram
CKEditorTableIcons {
string addRowBefore_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
string addRowAfter_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
string addColumnBefore_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
string addColumnAfter_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
string deleteRow_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
string deleteColumn_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
string mergeOrSplit_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
}
Class Diagram: Modification to Editor's Default Configuration MethodclassDiagram
class EditorConfigurationProvider {
+default(obj): dict
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PeterW-LWL - I've reviewed your changes - here's some feedback:
- Some SVG paths still have hard-coded fills (e.g. fill="#000000"); remove or replace those so the fill="currentColor" on the root can actually control all icon colors.
- There’s a lot of repeated SVG markup—consider refactoring these icon definitions (for example via a shared constant or template include) to avoid manual duplication when you need to tweak attributes like fill.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 14 14
Lines 941 941
Branches 110 110
=======================================
Hits 768 768
Misses 130 130
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@PeterW-LWL Well spotted! The circled minuses seem to still be black. Also, I noticed that some table icons contain a Thanks! |
8bdcd96
to
9eefa7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I noticed that some of the table icons did not respect the darkmode.
Before:

After:

@fsbraun can you review this?
Summary by Sourcery
Bug Fixes: