Skip to content

fix: table icons of inline ckeditor respect dark mode #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

PeterW-LWL
Copy link
Contributor

@PeterW-LWL PeterW-LWL commented May 26, 2025

I noticed that some of the table icons did not respect the darkmode.

Before:
Icons not "visible" in darkmode

After:
Icons now "visible" in darkmode

@fsbraun can you review this?

Summary by Sourcery

Bug Fixes:

  • Add fill="currentColor" to table icon SVGs so they adapt to dark mode

Copy link
Contributor

sourcery-ai bot commented May 26, 2025

Reviewer's Guide

Updated all table-related toolbar icons in the inline CKEditor to use fill="currentColor" instead of hardcoded colors so they automatically respect dark mode.

ER Diagram: Updates to CKEditor Table Icon Definitions

erDiagram
    CKEditorTableIcons {
        string addRowBefore_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
        string addRowAfter_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
        string addColumnBefore_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
        string addColumnAfter_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
        string deleteRow_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
        string deleteColumn_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
        string mergeOrSplit_icon_svg "SVG definition updated to use fill='currentColor' for dark mode compatibility"
    }
Loading

Class Diagram: Modification to Editor's Default Configuration Method

classDiagram
    class EditorConfigurationProvider {
        +default(obj): dict
    }
Loading

File-Level Changes

Change Details Files
Table action icons now inherit text color for dark mode support
  • Added fill="currentColor" to the SVG root for addRowBefore
  • Added fill="currentColor" to the SVG root for addRowAfter
  • Added fill="currentColor" to the SVG root for addColumnBefore
  • Added fill="currentColor" to the SVG root for addColumnAfter
  • Added fill="currentColor" to the SVG root for deleteRow
  • Added fill="currentColor" to the SVG root for deleteColumn
  • Added fill="currentColor" to the SVG root for mergeOrSplit
djangocms_text/editors.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PeterW-LWL - I've reviewed your changes - here's some feedback:

  • Some SVG paths still have hard-coded fills (e.g. fill="#000000"); remove or replace those so the fill="currentColor" on the root can actually control all icon colors.
  • There’s a lot of repeated SVG markup—consider refactoring these icon definitions (for example via a shared constant or template include) to avoid manual duplication when you need to tweak attributes like fill.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (df1b635) to head (9eefa7a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files          14       14           
  Lines         941      941           
  Branches      110      110           
=======================================
  Hits          768      768           
  Misses        130      130           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fsbraun
Copy link
Member

fsbraun commented May 26, 2025

@PeterW-LWL Well spotted! The circled minuses seem to still be black. Also, I noticed that some table icons contain a style="color: #000000". Can you check if those are needed (and potentially remove them)?

Thanks!

@PeterW-LWL
Copy link
Contributor Author

PeterW-LWL commented May 27, 2025

Also, I noticed that some table icons contain a style="color: #000000".

You are right. I found it and will append it here.

Fixed dark circles

@PeterW-LWL PeterW-LWL force-pushed the fix/darkmode-table-icons branch from 8bdcd96 to 9eefa7a Compare May 27, 2025 05:55
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fsbraun fsbraun merged commit 2ad84df into django-cms:main May 27, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants