Skip to content

feat: Add support for djangocms v4 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2025

Conversation

mrbazzan
Copy link
Contributor

@mrbazzan mrbazzan commented Mar 4, 2025

Description

  • Drop support for djangocms less than 3.11
  • remove test requirements file for dCMS <3.11
  • Add support for django-cms4.1
  • Add support for Python3.9 - 3.13

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Member

fsbraun commented Mar 4, 2025

@mrbazzan Great! Let's also add 3.12 & 3.13!

@mrbazzan
Copy link
Contributor Author

mrbazzan commented Mar 4, 2025

Wish I'd seen this earlier

Without an additional package installed that supports versioning all django CMS pages are published by default. This means they are visible to the public the moment you save them.

I wanted the v4 solution to Page.publish()

@mrbazzan mrbazzan changed the title feat: Drop support for djangocms less than 3.11 feat: Add support for djangocms v4 Mar 4, 2025
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got two suggestions to make the tests run on v3 and 4+

@fsbraun fsbraun merged commit 6b23339 into django-cms:master Mar 16, 2025
6 checks passed
@sveetch
Copy link

sveetch commented Mar 20, 2025

That is a great news to get this plugin to work again.

@fsbraun Hi, do you have planning about launching a new release with this merge PR ?

@fsbraun
Copy link
Member

fsbraun commented Mar 20, 2025

@sveetch @mrbazzan and myself are planning to give djangocms-picture a boost so that it can be used:

  • With multiple backends (e.g., filer, but also other solutions, like digital asset management)
  • With reusable Picture field

The objective is that all pictures can be handled by djangocms-picture and that other picture plugins (like djangocms-frontend's) actually depend and reuse picture's capabilities. Any support is welcome.

@sveetch
Copy link

sveetch commented Mar 21, 2025

@fsbraun @mrbazzan so what is the plan ? I don't see any issues about these improvements. I don't use djangocms-frontend and other media storages than the basic FS one so i don't know what i could do.

@fsbraun
Copy link
Member

fsbraun commented Mar 21, 2025

@sveetch The plan is to create a PictureField and PictureFormField that let's you select an image, potentially define its format, size, .... Those fields would be reusable in custom models or forms. We have to draw this out.

Giving feedback would be an awesome start to contribute :-) We'll be starting in the next weeks - so no hurry here.

Also, by focusing on collecting functionality at a one-stop shop we hope to have a better overall community support and contribution. (I your case: Improvements to the above fields would also benefit djangocms-frontend users, for example.)

@sveetch
Copy link

sveetch commented Mar 21, 2025

Where would be the discussion about this plan ? Are you opening a new issue ? or a github project ? or ... ?

And so if there is a run to be starting only in two weeks and that won't probably be finished until a month or more, could you at least release a 4.2.0 to deliver the DjangoCMS 4 support ? Because actually i'm starting to introduce use of djangocms-picture from the git commit with CMS4 support and i would largely prefer a package release.

Edit: For information i've used the commit from this merged PR in a project (Django5.0 + django-cms 4.1.4) and it works well.

@fsbraun
Copy link
Member

fsbraun commented Mar 21, 2025

@sveetch We'll start an issue and work from there.

djangocms-picture 4.1.4 works nicely with django CMS 4 (and upcoming 5). The PR just ensured it by extending the test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants