-
Notifications
You must be signed in to change notification settings - Fork 63
feat: Add support for djangocms v4 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mrbazzan Great! Let's also add 3.12 & 3.13! |
Wish I'd seen this earlier
I wanted the v4 solution to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got two suggestions to make the tests run on v3 and 4+
That is a great news to get this plugin to work again. @fsbraun Hi, do you have planning about launching a new release with this merge PR ? |
@sveetch @mrbazzan and myself are planning to give djangocms-picture a boost so that it can be used:
The objective is that all pictures can be handled by djangocms-picture and that other picture plugins (like djangocms-frontend's) actually depend and reuse picture's capabilities. Any support is welcome. |
@sveetch The plan is to create a PictureField and PictureFormField that let's you select an image, potentially define its format, size, .... Those fields would be reusable in custom models or forms. We have to draw this out. Giving feedback would be an awesome start to contribute :-) We'll be starting in the next weeks - so no hurry here. Also, by focusing on collecting functionality at a one-stop shop we hope to have a better overall community support and contribution. (I your case: Improvements to the above fields would also benefit djangocms-frontend users, for example.) |
Where would be the discussion about this plan ? Are you opening a new issue ? or a github project ? or ... ? And so if there is a run to be starting only in two weeks and that won't probably be finished until a month or more, could you at least release a 4.2.0 to deliver the DjangoCMS 4 support ? Because actually i'm starting to introduce use of djangocms-picture from the git commit with CMS4 support and i would largely prefer a package release. Edit: For information i've used the commit from this merged PR in a project (Django5.0 + django-cms 4.1.4) and it works well. |
@sveetch We'll start an issue and work from there. djangocms-picture 4.1.4 works nicely with django CMS 4 (and upcoming 5). The PR just ensured it by extending the test coverage. |
Description
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.