-
Notifications
You must be signed in to change notification settings - Fork 31
fix: Button group too condensed when using djangocms-admin-style #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds a djangocms-admin-style CSS override to prevent button groups from being overly condensed, adjusts the secondary color SCSS variable fallback, and cleans up generated CSS assets by removing redundant @charset declarations. Class diagram for updated SCSS variable fallback logicclassDiagram
class VariablesSCSS {
$color-primary: var(--primary)
$color-secondary: var(--dca-action-bg, var(--dca-primary, var(--header-bg)))
$color-gray: var(--dca-gray, var(--breadcrumbs-fg, #999))
$dark-fg: var(--dca-dark-fg, #333)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 124 124
Lines 3387 3387
Branches 288 288
=======================================
Hits 3019 3019
Misses 252 252
Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later
Summary by Sourcery
Fix CSS layout issues for button groups under Django admin style, enhance color variable fallback, and clean up generated CSS
Bug Fixes:
Enhancements:
Chores: