-
Notifications
You must be signed in to change notification settings - Fork 24
chore: Increase specificity for admin urls (django 5.2) #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request resolves an issue with unwanted underlines on admin navigation links in Django 5.2 by adjusting CSS specificity and explicitly removing text decoration. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 124 124
Lines 3366 3366
Branches 283 283
=======================================
Hits 2985 2985
Misses 264 264
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ad6fbf
to
a0638d9
Compare
This PR removes underline text decorations introduced by django 5.2 (through changes in specificity):
Summary by Sourcery
Bug Fixes: