Skip to content

Expose multiple headers with the same name in responses #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: series/0.18
Choose a base branch
from
Open

Expose multiple headers with the same name in responses #1747

wants to merge 2 commits into from

Conversation

@nviliunov-evolution-throwaway
Copy link

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kubukoz
kubukoz reviewed Jun 6, 2025
View reviewed changes
modules/http4s-kernel/src/smithy4s/http4s/kernel/package.scala
val headers = res.headers.headers
.map(h => CaseInsensitive(h.name.toString) -> Seq(h.value))
.toMap
.groupBy(h => CaseInsensitive(h.name.toString))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: wait, we've been silently dropping repeated headers in responses all this time? wow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least this would only happen on clients...

however, res.headers should already have a MultiMap-like representation. Let's use that instead of our own grouping, if possisble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kubukoz kubukoz kubukoz left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nviliunov-evolution-throwaway @CLAassistant @kubukoz