Isolation via null parent ClassLoader #1707
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
force-pushed
the
imagine-no-isolation
branch
from
ab5e6f9 to
6ca4370
Compare
kubukoz
changed the title
Comment on lines
+51
to
+55
| val cp = resolveDependencies( | ||
| s"com.disneystreaming.smithy4s:smithy4s-codegen-cli_2.13:${BuildInfo.version}" :: | ||
| args.dependencies, | ||
| args.localJars, | ||
| args.repositories |
There was a problem hiding this comment.
Very clever 👍
There is one downside though:
This is not ideal as coursier's resolution will just pick the latest versions preventing users from using anything older than what codegen was compiled against.
But maybe this is good enough trade-off given its low complexity? 🤔
There was a problem hiding this comment.
imo this is actually good 😅 if you used older things you might be risking that the old version is not going to work with the codegen anyway, i.e. it might not be compliant with more recent requirements in the smithy model etc.
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)