Skip to content

Conversation

@kubukoz
Copy link
Member

@kubukoz kubukoz commented Jan 26, 2024

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@Baccata
Copy link
Contributor

Baccata commented May 17, 2024

besides the fact that this actually sets up fore-port (not back-port), do you want to revisit this in order to automate the process a little more ?

@kubukoz
Copy link
Member Author

kubukoz commented May 17, 2024

yes. PR is called "backport action" because that's how Mergify calls it in the config ;)

I may try revisiting it now that you've sniped me

@kubukoz kubukoz changed the title Add Mergify backport action Add 0.18 forward-porting into 0.19 May 17, 2024
conditions:
- author=scala-steward
- status-success="build-success-checkpoint"
- check-success="build-success-checkpoint"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status-success apparently isn't a thing - https://docs.mergify.com/configuration/conditions/

@kubukoz
Copy link
Member Author

kubukoz commented Apr 25, 2025

@Baccata that should do it. Tested in a repo of mine (without the required status check, but I trust that'll work properly) - kubukoz/demos#8

@kubukoz kubukoz marked this pull request as ready for review April 25, 2025 00:14
Comment on lines +15 to +16
conditions:
- label="forwardport-0.19"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we need a label? I'd say we should do it automatically (that way it'll be much less trouble with things like Steward), or with opt-out via a "do not port" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants