feat: add missing opts for cache config #480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the current release candidate (v0.19.0-rc.7) found out the issue with cache config:
config struct is now private, we as library users cannot directly set it's fields other than using With opts.
Before, if a config opt was missing, I could use something like:
But now some of With opts are missing, making it impossible to workaround.
So here I implemented missing opts. Also I checked every other place where config opts pattern is used, and probably cache package is the only place where I found issues.