Improve voice state event selection logic #395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, we verify if the old state is valid and whether its channel ID is not nil. This indicates that the user has left a voice channel. Next, we check if the event includes a new channel ID. This indicates that the user has joined a new voice channel.
oldOk && oldVoiceState.ChannelID != nil && event.ChannelID != nilThe first part (
(oldOk || oldVoiceState.ChannelID == nil)) of the next comparison is redundant. We already confirmed whether a move took place, so if the event's channel ID is not nil, it must be a join.In my opinion the last comparison is flawed. We don't really check whether there was an old voice state. If the old state is invalid, we have not left a channel. According to the old logic, a leave still takes place, even if only the new channel ID is not equal to nil.