This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: Multiple topics may have the same post as its solution #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Mar 26, 2025
Comment on lines
+41
to
+42
| ROW_NUMBER() OVER (PARTITION BY tc.topic_id ORDER BY tc.created_at ASC) AS rn_topic, | ||
| ROW_NUMBER() OVER (PARTITION BY CAST(tc.value AS INTEGER) ORDER BY tc.created_at ASC) AS rn_answer |
There was a problem hiding this comment.
We need this partition because one post can be the answer to many topics. The migration after this one 20250318025147_add_index_for_discourse_solved_topics was adding an index and failing.
PG::UniqueViolation: ERROR: could not create unique index \"index_discourse_solved_solved_topics_on_answer_post_id\"
DETAIL: Key (answer_post_id)=(13006) is duplicated.\n">
nattsw
commented
Mar 26, 2025
| @@ -0,0 +1,31 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class RemoveDuplicatesFromDiscourseSolvedSolvedTopics < ActiveRecord::Migration[7.2] | |||
There was a problem hiding this comment.
We're adding this new migration in between the copy and the failed add-index migration to remove the duplicate entries.
nattsw
commented
Mar 26, 2025
Comment on lines
+10
to
+15
| ActiveRecord::Base.connection.execute( | ||
| "DROP INDEX IF EXISTS index_discourse_solved_solved_topics_on_topic_id;", | ||
| ) | ||
| ActiveRecord::Base.connection.execute( | ||
| "DROP INDEX IF EXISTS index_discourse_solved_solved_topics_on_answer_post_id;", | ||
| ) |
There was a problem hiding this comment.
To create the duplicate entries below to test the migration, we needed to drop the index first.
romanrizzi
approved these changes
Mar 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing some errors when migrating and adding indexes on
answer_post_id.This PR modifies the earlier migration, and also adds one before the addition of indexes to remove duplicates.