Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Oct 31, 2024

No description provided.

@CvX CvX merged commit c2f549f into main Oct 31, 2024
4 checks passed
@CvX CvX deleted the owner branch October 31, 2024 09:56
@wjt
Copy link

wjt commented Dec 3, 2024

I'm probably overlooking something but as far as I can tell, the corresponding change to discourse itself – discourse/discourse@dc96b6e – is not part of the latest stable release, 3.3.2. So the current main of discourse-solved cannot be used with the current stable release of discourse:

Uncaught TypeError: Cannot read properties of undefined (reading 'lookup')
    at shouldRender (solved-status-filter.js:19:1)
    at plugin-connectors.js:230:29
    ...

I don't see a tag or branch that I should track in this repo for a version compatible with the current discourse stable release. What's recommended the recommended approach? Pinning the commit before this change?

@CvX
Copy link
Contributor Author

CvX commented Dec 3, 2024

In production environment we're using .discourse-compatibility file to checkout the right version of a plugin. See the docs on meta.

In a dev env you'd have to manually checkout a commit from that list corresponding to the version you're working with.

@wjt
Copy link

wjt commented Dec 3, 2024

That's great, thank you for the pointers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants