Skip to content

fix: Miscellaneous fixes #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 1, 2023
Merged

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Apr 23, 2023

Please describe the changes this PR makes and why it should be merged:

Backports:

Status and versioning classification:

  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

jaw0r3k and others added 6 commits April 23, 2023 14:55
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
…ordjs#9326)

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
…djs#9335)

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
…#9327)

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 1, 2023 4:40pm
discord-js-guide ⬜️ Ignored (Inspect) May 1, 2023 4:40pm

@Jiralite
Copy link
Member

Backports some prs

Please include them in the description so it's clear.

@Jiralite Jiralite added this to the discord.js 13.16 milestone Apr 23, 2023
jaw0r3k and others added 2 commits April 23, 2023 20:59
Co-authored-by: kyranet <kyradiscord@gmail.com>
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URLs are still wrong. They should be https://old.discordjs.dev/#/docs. You've added a . between "discord" and "js".

@Jiralite
Copy link
Member

Backport #9343 too. Currently, the links to the new documentation are using the main branch. They should use the stable helper, at least.

@jaw0r3k jaw0r3k force-pushed the v13-some_docs_changes branch from aa853f2 to cf72962 Compare April 23, 2023 19:16
@Jiralite
Copy link
Member

I'm changing the scope of this pull request to "fix:" instead. Unfortunately, the last pull request did not come up in the changelog because it was a "chore:" leaving these fixes out.

@Jiralite Jiralite changed the title chore: miscellaneous fixes fix: Miscellaneous fixes Apr 23, 2023
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@iCrawl iCrawl requested review from Jiralite and kyranet May 1, 2023 15:11
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you apply the changes from #9343 (as listed in the description) please?

@iCrawl iCrawl merged commit 21dfac9 into discordjs:v13 May 1, 2023
@jaw0r3k jaw0r3k deleted the v13-some_docs_changes branch May 1, 2023 19:06
@Jiralite Jiralite removed the blocked label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants