-
-
Notifications
You must be signed in to change notification settings - Fork 4k
chore: Include discord.js in the user agent string #9267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Aura Román <kyradiscord@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #9267 +/- ##
===========================================
+ Coverage 59.92% 79.79% +19.87%
===========================================
Files 214 123 -91
Lines 13721 10309 -3412
Branches 1245 1155 -90
===========================================
+ Hits 8222 8226 +4
+ Misses 5459 2043 -3416
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 99 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, shouldn't /rest's default user agent URL point to the new docs (https://discordjs.dev/docs/packages/rest
or something), or use @discordjs/rest@<version>
in the version itself? Currently, it's set to DiscordBot (https://discord.js.org, 1.6.0)
From https://discord.com/developers/docs/reference#user-agent-user-agent-example, there doesn't seem to be a place to include |
@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
Please describe the changes this PR makes and why it should be merged:
This includes discord.js in the user agent string, even if a custom appendix is supplied.
Status and versioning classification: