Skip to content

Update Message.js #9215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Sheikh-JamirAlam
Copy link

Please describe the changes this PR makes and why it should be merged:
Changed docs BaseMessageCreateOptions to BaseMessageOptions at line 816 in packages/discord.js/src/structures/Message.js
Fixes #9209
Status and versioning classification:
This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 0:38AM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 0:38AM (UTC)

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extending BaseMessageOptions isn't correct. It's missing properties, such as tts, flags, nonce etc.

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see @Jiralite's request.

@Jiralite
Copy link
Member

Superseded by #9283.

@Jiralite Jiralite closed this Apr 12, 2023
@Jiralite Jiralite added this to the discord.js 14.10 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

MessageReplyOptions references non-existent type definition BaseMessageCreateOptions
3 participants