Skip to content

feat(webhook): Support with_components #10945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025
Merged

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2025 8:54am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2025 8:54am

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.69%. Comparing base (2852a52) to head (f114057).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/api/webhook.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10945   +/-   ##
=======================================
  Coverage   42.69%   42.69%           
=======================================
  Files         262      262           
  Lines       16086    16086           
  Branches     1545     1545           
=======================================
  Hits         6868     6868           
  Misses       9206     9206           
  Partials       12       12           
Flag Coverage Δ
core 0.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite force-pushed the feat/with-components-core branch from 65db9f6 to f114057 Compare June 22, 2025 08:54
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Jun 22, 2025
@kodiakhq kodiakhq bot merged commit cbb2056 into main Jun 22, 2025
26 checks passed
@kodiakhq kodiakhq bot deleted the feat/with-components-core branch June 22, 2025 09:42
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jun 22, 2025
Jiralite added a commit that referenced this pull request Jun 22, 2025
feat: support `with_components`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants