Skip to content

feat(GuildMember): add avatarDecorationData #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2025
Merged

feat(GuildMember): add avatarDecorationData #10942

merged 4 commits into from
Jun 22, 2025

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #10940

Also removes leftover parameter from User#avatarDecorationURL

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@sdanialraza sdanialraza added this to the discord.js 15.0.0 milestone Jun 21, 2025
@sdanialraza sdanialraza requested a review from a team as a code owner June 21, 2025 12:09
@sdanialraza sdanialraza requested review from vladfrangu and iCrawl June 21, 2025 12:09
@sdanialraza sdanialraza requested review from kyranet and SpaceEEC June 21, 2025 12:09
@vercel Vercel
Copy link

vercel bot commented Jun 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2025 10:20pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2025 10:20pm

Jiralite
Jiralite reviewed Jun 21, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a displayAvatarDecoration() method now that attempts getting data from the guild member then the user?

@sdanialraza sdanialraza requested a review from Jiralite June 21, 2025 12:43
Jiralite
Jiralite previously requested changes Jun 21, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Jun 21, 2025
@sdanialraza sdanialraza requested a review from Jiralite June 21, 2025 12:52
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Jun 22, 2025
@kodiakhq kodiakhq bot merged commit 01c2fbe into main Jun 22, 2025
26 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-avatar-decoration-data branch June 22, 2025 22:21
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support backport-candidate packages:discord.js semver:minor
Projects
discord.js
Status: Done
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.

Add avatar decorations to GuildMember
4 participants
@sdanialraza @vladfrangu @Jiralite @Qjuh