feat(User): add guildtag property to User class #10941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add guildtag property that reads from primary_guild.tag in API response - Update equals and _equals methods to include guildtag comparison - Add TypeScript type definition for guildtag property - Support for accessing user's primary guild tag via user.guildtag
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Yu-yu0202
changed the title
|
We do not implement undocumented features. Upstream (guessing): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a
guildtagproperty to the User class to provide access to a user's primary guild tag from the Discord API. The guildtag represents the tag associated with a user's primary guild identity, which is useful for displaying guild affiliations and implementing guild-based features.Changes Made:
guildtagproperty to User class that reads fromprimary_guild.tagin API(v10/users) responseequalsmethod to include guildtag comparison between User instances_equalsmethod to include guildtag comparison with API user objectsstring | null)toJSONmethod to include guildtag in serialized outputWhy this should be merged:
Status and versioning classification: