Skip to content

docs: Replace base64 encoded image with proper svg #10929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prem-k-r
Copy link

@prem-k-r prem-k-r commented Jun 10, 2025

The favicon.svg was actually just a base64 encoded PNG. It wasn't a proper scalable SVG.
Built svg from the main logo

D.JS in the svg is 1/sqrt(2) * width and placed horizontally and vertically center.
Also optimized the path using SVGO

Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

@prem-k-r prem-k-r requested a review from a team as a code owner June 10, 2025 19:04
@prem-k-r prem-k-r requested review from iCrawl, Jiralite and Qjuh June 10, 2025 19:04
Copy link

vercel bot commented Jun 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 7:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2025 7:06pm

@Qjuh
Copy link
Member

Qjuh commented Jun 13, 2025

I'm not convinced this is an improvement:

  • this is a favicon, it won't ever show anywhere in a size were being scalable matters
  • on mobile safari the new svg icon actually looks worse than the png (maybe because safari sucks at rendering SVG)

@prem-k-r
Copy link
Author

  • on mobile safari the new svg icon actually looks worse than the png (maybe because safari sucks at rendering SVG)

Ah ok, nevermind then

Thanks for the review, closing this.

The svg can be useful to get high quality image.

like:

DISCORD JS

@prem-k-r prem-k-r closed this Jun 13, 2025
@github-project-automation github-project-automation bot moved this from Todo to Denied in discord.js Jun 13, 2025
@prem-k-r prem-k-r deleted the favicon-svg branch June 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Denied
Development

Successfully merging this pull request may close these issues.

4 participants