Skip to content

feat: update @types/node to v22 #10926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

feat: update @types/node to v22 #10926

merged 1 commit into from
Jun 7, 2025

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jun 7, 2025

This brings the @types/node version of the @discordjs/rest package in sync with the other packages.
The node engine version was already increased to v22.

@types/node comes with undici-types v6, and we have undici v7. Hence the type mismatch

Copy link

vercel bot commented Jun 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jun 7, 2025 11:25am
discord-js-guide ⬜️ Ignored (Inspect) Jun 7, 2025 11:25am

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.69%. Comparing base (9708717) to head (498407f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/rest/src/web.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10926   +/-   ##
=======================================
  Coverage   42.69%   42.69%           
=======================================
  Files         262      262           
  Lines       16086    16086           
  Branches     1545     1545           
=======================================
  Hits         6868     6868           
  Misses       9206     9206           
  Partials       12       12           
Flag Coverage Δ
core 0.89% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.67% <66.66%> (ø)
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Jun 7, 2025
@kodiakhq kodiakhq bot merged commit 8e03af6 into main Jun 7, 2025
30 checks passed
@kodiakhq kodiakhq bot deleted the feat/node-22-rest branch June 7, 2025 13:21
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants