Skip to content

feat!: Support animated WebP #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

feat!: Support animated WebP #10911

merged 3 commits into from
May 27, 2025

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

BREAKING CHANGE: "webp?animated=true" is now the default for animated assets.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 26, 2025 10:49pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 26, 2025 10:49pm

Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.69%. Comparing base (78d512c) to head (05ed86f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10911      +/-   ##
==========================================
+ Coverage   42.68%   42.69%   +0.01%     
==========================================
  Files         262      262              
  Lines       16095    16099       +4     
  Branches     1547     1548       +1     
==========================================
+ Hits         6870     6874       +4     
  Misses       9213     9213              
  Partials       12       12              
Flag Coverage Δ
core 0.89% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.80% <100.00%> (+0.04%) ⬆️
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets backport as much as possible 🙏

Copy link
Member

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that question LGTM

@Jiralite Jiralite force-pushed the feat/animated-webp branch from 2b55f82 to 05ed86f Compare May 26, 2025 22:49
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js May 26, 2025
@Jiralite Jiralite merged commit 2c35084 into main May 27, 2025
26 checks passed
@Jiralite Jiralite deleted the feat/animated-webp branch May 27, 2025 09:18
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants