Skip to content

fix(website): constructors show on too many items #10880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented May 3, 2025

Please describe the changes this PR makes and why it should be merged:

Because all instances in JS have a .constructor property the check in website was checking the wrong thing and the docs were overwriting that property.

This PR fixes that by renaming the property of the docs to document constructors.

Down side: all docs need to be regenerated after this merges or no constructors will show in docs.

Status and versioning classification:

@Qjuh Qjuh requested review from a team as code owners May 3, 2025 20:07
@Qjuh Qjuh requested review from ckohen, vladfrangu, iCrawl and almeidx May 3, 2025 20:07
@Qjuh Qjuh requested a review from Jiralite May 3, 2025 20:07
Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2025 8:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 3, 2025 8:09pm

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js May 3, 2025
@kodiakhq kodiakhq bot merged commit 65f41be into discordjs:main May 3, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js May 3, 2025
@Qjuh Qjuh deleted the website/fix-constructor branch May 14, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants