Skip to content

chore: remove container limit #10867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Apr 29, 2025

Please describe the changes this PR makes and why it should be merged:

Removes the assertion limiting amount of components in a container

Also adds .setValidationEnabled(isValidationEnabled) to two shapes that were missing it.

Status and versioning classification:

@Qjuh Qjuh requested a review from a team as a code owner April 29, 2025 21:10
@Qjuh Qjuh requested review from vladfrangu, iCrawl, kyranet, didinele and Jiralite and removed request for a team April 29, 2025 21:10
Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2025 4:59pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2025 4:59pm

Copy link

vercel bot commented Apr 29, 2025

@Qjuh is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.41%. Comparing base (f8d7b1c) to head (95d85f0).
Report is 1 commits behind head on builders/1.x.

Additional details and impacted files
@@               Coverage Diff                @@
##           builders/1.x   #10867      +/-   ##
================================================
- Coverage         37.42%   37.41%   -0.01%     
================================================
  Files               237      237              
  Lines             14773    14773              
  Branches           1345     1345              
================================================
- Hits               5529     5528       -1     
- Misses             9200     9201       +1     
  Partials             44       44              
Flag Coverage Δ
builders 93.37% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 30, 2025
@Qjuh Qjuh merged commit e6370ae into discordjs:builders/1.x Apr 30, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 30, 2025
@Qjuh Qjuh deleted the chore/builders-v1-comp-limit branch April 30, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants