Skip to content

chore: move pnpm settings to pnpm-workspace.yaml #10828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Apr 7, 2025

Since pnpm 10.5 and 10.6, the pnpm-workspace.yaml file can hold settings from package.json's pnpm key and .npmrc files.

Upgrade pnpm to 10.8

Removed the resolution-mode=highest setting as that is the default value

Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2025 5:38pm

@almeidx almeidx requested review from a team and iCrawl as code owners April 7, 2025 19:50
@Jiralite Jiralite added the chore label Apr 7, 2025
Jiralite
Jiralite previously approved these changes Apr 7, 2025
sdanialraza
sdanialraza previously approved these changes Apr 7, 2025
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.69%. Comparing base (3b76c70) to head (457b09c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10828   +/-   ##
=======================================
  Coverage   41.69%   41.69%           
=======================================
  Files         251      251           
  Lines       15077    15077           
  Branches     1454     1454           
=======================================
  Hits         6287     6287           
  Misses       8778     8778           
  Partials       12       12           
Flag Coverage Δ
brokers 31.41% <ø> (ø)
builders 78.50% <ø> (ø)
collection 100.00% <ø> (ø)
formatters 99.63% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.69% <ø> (ø)
util 43.28% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 70.90% <ø> (ø)
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite dismissed stale reviews from sdanialraza and themself April 10, 2025 14:28

Stale.

@almeidx almeidx requested a review from Qjuh April 10, 2025 15:16
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 10, 2025
@kodiakhq kodiakhq bot merged commit 1fe53c7 into main Apr 10, 2025
24 checks passed
@kodiakhq kodiakhq bot deleted the chore/move-pnpm-settings branch April 10, 2025 17:42
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants