fix(PollAnswer): only define _emoji property once #10811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Qjuh
approved these changes
Mar 21, 2025
didinele
approved these changes
Mar 21, 2025
sdanialraza
approved these changes
Mar 21, 2025
Jiralite
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the error "TypeError: Cannot redefine property: _emoji" by modifying how the _emoji property is defined and updated in PollAnswer.js. The key changes are:
- The _emoji property is now defined only once with writable set to true.
- The subsequent update of _emoji uses a direct assignment instead of re-defining the property.
Comments suppressed due to low confidence (1)
packages/discord.js/src/structures/PollAnswer.js:42
- Ensure that making _emoji writable does not allow unintended external modifications elsewhere. If strict encapsulation is required, consider providing controlled access via a getter/setter.
Object.defineProperty(this, '_emoji', { value: null, writable: true });
kyranet
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes an error
TypeError: Cannot redefine property: _emoji.