fix: message builders #10802
Merged
fix: message builders #10802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
requested review from
vladfrangu,
iCrawl,
kyranet,
didinele and
Jiralite
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
force-pushed
the
fix/message-builders
branch
from
1cdd834 to
ec66fee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10802 +/- ##
==========================================
+ Coverage 44.43% 44.60% +0.16%
==========================================
Files 260 260
Lines 15329 15363 +34
Branches 1544 1549 +5
==========================================
+ Hits 6812 6852 +40
+ Misses 8505 8499 -6
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vladfrangu
previously requested changes
Mar 15, 2025
Qjuh
approved these changes
Apr 20, 2025
Qjuh
previously requested changes
Apr 20, 2025
almeidx
force-pushed
the
fix/message-builders
branch
from
ec66fee to
6eca42c
Compare
|
Please resolve conflicts! |
- Added `clearParse`, `clearRoles`, and `clearUsers` methods to the `AllowedMentionsBuilder`, since passing an empty array and omitting the these fields behave differently - Strictened assertions - Removed `AttachmentBuilder#clearId`, as it is a required field - Added missing `MessageBuilder#setEmbeds` - Added missing `MessageReferenceBuilder#setFailIfNotExists` - Improve/fix documentation - Consistency:tm:
almeidx
force-pushed
the
fix/message-builders
branch
from
6eca42c to
6aae36c
Compare
Qjuh
approved these changes
Apr 23, 2025
vladfrangu
approved these changes
Apr 25, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearParse,clearRoles, andclearUsersmethods to theAllowedMentionsBuilder, since passing an empty array and omitting the these fields behave differentlyAttachmentBuilder#clearId, as it is a required fieldvoidMessageBuilder#setEmbedsMessageReferenceBuilder#setFailIfNotExists