Skip to content

feat: message builder #10793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2025
Merged

feat: message builder #10793

merged 8 commits into from
Mar 14, 2025

Conversation

didinele
Copy link
Member

@didinele didinele commented Mar 5, 2025

much builder

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 2:21pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 2:21pm

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 57.46269% with 171 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (ab6a694) to head (643d1d3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/builders/src/messages/Message.ts 54.01% 86 Missing ⚠️
packages/builders/src/messages/Attachment.ts 50.00% 30 Missing ⚠️
packages/builders/src/messages/AllowedMentions.ts 41.66% 28 Missing ⚠️
packages/builders/src/messages/MessageReference.ts 47.50% 21 Missing ⚠️
packages/builders/src/messages/Assertions.ts 91.04% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10793      +/-   ##
==========================================
+ Coverage   39.15%   39.66%   +0.51%     
==========================================
  Files         244      249       +5     
  Lines       14804    15206     +402     
  Branches     1413     1456      +43     
==========================================
+ Hits         5796     6031     +235     
- Misses       8996     9163     +167     
  Partials       12       12              
Flag Coverage Δ
builders 76.86% <57.46%> (-3.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@didinele didinele force-pushed the feat/message-builder branch 2 times, most recently from c2c8d0b to 0d75c94 Compare March 7, 2025 09:31
@didinele didinele added this to the builders 2.0.0 milestone Mar 7, 2025
@didinele didinele marked this pull request as ready for review March 7, 2025 09:31
@didinele didinele requested a review from a team as a code owner March 7, 2025 09:31
@didinele didinele force-pushed the feat/message-builder branch from 8cd7564 to 0fde4a1 Compare March 7, 2025 09:32
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Mar 7, 2025
@Jiralite Jiralite dismissed their stale review March 7, 2025 11:22

Resolved.

didinele and others added 4 commits March 10, 2025 12:06
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@didinele didinele force-pushed the feat/message-builder branch from 9332a34 to 8438f94 Compare March 10, 2025 10:06
@didinele didinele requested a review from vladfrangu March 10, 2025 10:06
@didinele didinele requested a review from Jiralite March 10, 2025 10:06
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@didinele didinele requested a review from vladfrangu March 13, 2025 14:21
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Mar 14, 2025
@kodiakhq kodiakhq bot merged commit 09beb8a into main Mar 14, 2025
25 checks passed
@kodiakhq kodiakhq bot deleted the feat/message-builder branch March 14, 2025 08:09
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants