Skip to content

fix: poll builders #10783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025
Merged

fix: poll builders #10783

merged 3 commits into from
Mar 1, 2025

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Feb 28, 2025

  • Fixed validations
  • Added missing documentation
  • Removed redundant code
  • Consistency™️

- Fixed validations
- Added missing documentation
- Removed redundant code
- Consistency™️
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2025 0:30am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2025 0:30am

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.12%. Comparing base (88bfeaa) to head (ae229ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/builders/src/messages/poll/PollAnswer.ts 66.66% 2 Missing ⚠️
packages/builders/src/messages/poll/Poll.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10783   +/-   ##
=======================================
  Coverage   39.12%   39.12%           
=======================================
  Files         244      244           
  Lines       14796    14798    +2     
  Branches     1412     1412           
=======================================
+ Hits         5789     5790    +1     
- Misses       8995     8996    +1     
  Partials       12       12           
Flag Coverage Δ
builders 80.82% <72.72%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite added this to the builders 2.0.0 milestone Feb 28, 2025
@almeidx almeidx requested a review from Qjuh March 1, 2025 12:29
@almeidx almeidx force-pushed the fix/poll-builders branch from dd8824f to ae229ae Compare March 1, 2025 12:30
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Mar 1, 2025
@kodiakhq kodiakhq bot merged commit d1f56ff into main Mar 1, 2025
25 checks passed
@kodiakhq kodiakhq bot deleted the fix/poll-builders branch March 1, 2025 14:57
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants