fix: Do not omit falsy default values #10755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
approved these changes
Feb 12, 2025
Jiralite
changed the title
Jiralite
approved these changes
Feb 12, 2025
kyranet
approved these changes
Feb 12, 2025
didinele
approved these changes
Feb 12, 2025
…entirely different
almeidx
approved these changes
Feb 12, 2025
Jiralite
changed the title
iCrawl
approved these changes
Feb 12, 2025
peschwartz
pushed a commit
to DD2480-Group22-2025/DD2480-discord.js
that referenced
this pull request
Feb 18, 2025
* fix(docs): fix default falsy values being omitted * fix(docs): swap defaultValue check to avoid negated condition * fix: fix pr by removing everything it added and committing something entirely different --------- Co-authored-by: almeidx <github@almeidx.dev> doc/setup initial documentation files Update issue templates
carltestar
added a commit
to DD2480-Group22-2025/DD2480-discord.js
that referenced
this pull request
Feb 20, 2025
* fix: Do not omit falsy default values (discordjs#10755) * fix(docs): fix default falsy values being omitted * fix(docs): swap defaultValue check to avoid negated condition * fix: fix pr by removing everything it added and committing something entirely different --------- Co-authored-by: almeidx <github@almeidx.dev> doc/setup initial documentation files Update issue templates * docs: onboarding written * feat: lizard analysis of code complexity Update issue templates fix: update functions docs: add guidelines * fix: update functions * doc: answers task 3.4 part 1 (#21) * Elaborates on onboarding document (#22) * docs: elaborates on onboarding document #2 * Update onboarding.md Says tests instead of tasks Closes #2 --------- Co-authored-by: Jacmol <104684303+Jacmol@users.noreply.github.com> Update complexity.md * docs: added coverage measurement documentation * docs: update documentation for refactoring feat: refactor thread patch reduces cyclomatic complexity in patch function in thread. #9 fix: moved files around Doc/coverage measurement improvement (#27) * docs: branchcoverage tool wip #13 * docs: improves #13 * docs: refactord guild.js patch function for #9 * Small fix #5 * docs: finish #13 * Revert "Small fix #5" This reverts commit 8513b3f. * docs: improved refactor for guild.js patch file #9 --------- Co-authored-by: Klara Lindemalm <klara.lindemalm@gmail.com> * docs: added documentation for refactor #26 (#28) Update complexity.md * feat: branch coverage and refactoring * fix: Updated log message for patch.test.js --------- Co-authored-by: Amgelo563 <61554601+Amgelo563@users.noreply.github.com> Co-authored-by: phoebe <phoebes@kth.se> Co-authored-by: Samuel Söderberg <samuelsoderberg99@gmail.com> Co-authored-by: Klara Lindemalm <klara.lindemalm@gmail.com> Co-authored-by: Phoebe Schwartz <144394710+peschwartz@users.noreply.github.com> Co-authored-by: Carltestar <carllon@kth.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes default falsy values not showing up on docs, like
BaseFetchOptions' force:Status and versioning classification: