refactor(Client)!: Remove emojis getter #10754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
changed the title
sdanialraza
requested changes
Feb 12, 2025
11 tasks
Co-authored-by: Danial Raza <danialrazafb@gmail.com>
Co-authored-by: Danial Raza <danialrazafb@gmail.com>
…into nuke-emojis
kyranet
approved these changes
Feb 13, 2025
sdanialraza
approved these changes
Feb 13, 2025
didinele
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
With the introductions of application emojis, accessed using
<ClientApplication>.emojis, this naming has become confusing, since it only includes guild emojis.Adding application emojis to Client#emojis is not an option since those require fetching.
Other factors are that it can cause performance issues, and, well, the fact app emojis now exist.
Status and versioning classification: