Skip to content

build: Update undici to 6.21.1 #10743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

LoboMetalurgico
Copy link
Contributor

@LoboMetalurgico LoboMetalurgico commented Feb 7, 2025

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

Closes #10729

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 10:46pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 10:46pm

@imnaiyar
Copy link
Contributor

imnaiyar commented Feb 7, 2025

Lockfile still remains unchanged as pointed out in that pr

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @imnaiyar said above, and please keep it pinned.

@LoboMetalurgico
Copy link
Contributor Author

Lockfile still remains unchanged as pointed out in that pr

Sorry, failed to commit. I'll force-push to fix it.

@LoboMetalurgico LoboMetalurgico changed the title Fix undici vulnerability warning (bump version to 6.21.1) (fix): undici vulnerability warning (bump version to 6.21.1) Feb 7, 2025
@LoboMetalurgico LoboMetalurgico changed the title (fix): undici vulnerability warning (bump version to 6.21.1) fix: undici vulnerability warning (bump version to 6.21.1) Feb 7, 2025
@LoboMetalurgico
Copy link
Contributor Author

Fixed, sorry for the delay

@Jiralite
Copy link
Member

Jiralite commented Feb 7, 2025

The versions are still unpinned.

@LoboMetalurgico
Copy link
Contributor Author

The versions are still unpinned.

Fixed real

@Jiralite Jiralite changed the title fix: undici vulnerability warning (bump version to 6.21.1) build: Update undici to 6.21.1 Feb 7, 2025
@Jiralite Jiralite dismissed their stale review February 7, 2025 23:26

Resolved.

@almeidx almeidx linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.67%. Comparing base (2183c5e) to head (8bdf5d7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10743      +/-   ##
==========================================
+ Coverage   38.65%   38.67%   +0.01%     
==========================================
  Files         239      239              
  Lines       14649    14653       +4     
  Branches     1385     1385              
==========================================
+ Hits         5663     5667       +4     
  Misses       8974     8974              
  Partials       12       12              
Flag Coverage Δ
brokers 28.80% <ø> (ø)
builders 80.61% <ø> (+0.04%) ⬆️
collection 100.00% <ø> (ø)
formatters 99.63% <ø> (ø)
proxy 64.63% <ø> (ø)
rest 87.33% <ø> (ø)
util 41.42% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 69.99% <ø> (ø)
ws 34.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 5c48979 into discordjs:main Feb 10, 2025
24 checks passed
@LoboMetalurgico LoboMetalurgico deleted the fix/undici branch February 10, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Node.js Vulnerability in Dependencies
6 participants