feat(collection): honour subclassing via @@species in static methods
#10723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renegade334
requested review from
ckohen,
vladfrangu,
iCrawl,
kyranet,
didinele,
Jiralite and
almeidx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Renegade334
commented
Jan 21, 2025
Renegade334
force-pushed
the
collection-static-inheritance
branch
2 times, most recently
from
8166bd8 to
472b938
Compare
|
Can you add tests for this? |
|
Subclassing is currently not tested at all, which is why I didn't add any. If tests are desirable here, then they probably also need adding for the other methods as well? |
Renegade334
force-pushed
the
collection-static-inheritance
branch
from
472b938 to
c2e4656
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10723 +/- ##
==========================================
+ Coverage 38.00% 38.60% +0.59%
==========================================
Files 239 239
Lines 14894 14664 -230
Branches 1392 1390 -2
==========================================
Hits 5661 5661
+ Misses 9221 8991 -230
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
almeidx
approved these changes
Jan 24, 2025
Jiralite
approved these changes
Jan 24, 2025
benjGam
approved these changes
Jan 24, 2025
SpaceEEC
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Collection methods feature subclassing support via
Symbol.species. This currently doesn't apply to the one static method, which calls the Collection constructor specifically.This change brings the behaviour of static methods in line with instance methods, such that
DerivedCollection.combineEntries(...)returns a DerivedCollection, not a Collection.