Skip to content

feat: add auth option in api methods #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2025
Merged

feat: add auth option in api methods #10717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b08e0b
feat: add `auth` option in api methods
almeidx Jan 19, 2025
0fb9900
Merge branch 'main' into feat/auth-option
Jiralite Jan 24, 2025
17d9149
Merge branch 'main' into feat/auth-option
didinele Jan 24, 2025
0f82c07
Merge branch 'main' into feat/auth-option
kodiakhq[bot] Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions packages/core/src/api/applicationCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ export class ApplicationCommandsAPI {
public async getGlobalCommands(
applicationId: Snowflake,
query: RESTGetAPIApplicationCommandsQuery = {},
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.applicationCommands(applicationId), {
auth,
query: makeURLSearchParams(query),
signal,
}) as Promise<RESTGetAPIApplicationCommandsResult>;
Expand All @@ -61,9 +62,10 @@ export class ApplicationCommandsAPI {
public async createGlobalCommand(
applicationId: Snowflake,
body: RESTPostAPIApplicationCommandsJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.post(Routes.applicationCommands(applicationId), {
auth,
body,
signal,
}) as Promise<RESTPostAPIApplicationCommandsResult>;
Expand All @@ -80,9 +82,10 @@ export class ApplicationCommandsAPI {
public async getGlobalCommand(
applicationId: Snowflake,
commandId: Snowflake,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.applicationCommand(applicationId, commandId), {
auth,
signal,
}) as Promise<RESTGetAPIApplicationCommandResult>;
}
Expand All @@ -100,9 +103,10 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
commandId: Snowflake,
body: RESTPatchAPIApplicationCommandJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.patch(Routes.applicationCommand(applicationId, commandId), {
auth,
body,
signal,
}) as Promise<RESTPatchAPIApplicationCommandResult>;
Expand All @@ -119,9 +123,9 @@ export class ApplicationCommandsAPI {
public async deleteGlobalCommand(
applicationId: Snowflake,
commandId: Snowflake,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
await this.rest.delete(Routes.applicationCommand(applicationId, commandId), { signal });
await this.rest.delete(Routes.applicationCommand(applicationId, commandId), { auth, signal });
}

/**
Expand All @@ -135,9 +139,10 @@ export class ApplicationCommandsAPI {
public async bulkOverwriteGlobalCommands(
applicationId: Snowflake,
body: RESTPutAPIApplicationCommandsJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.put(Routes.applicationCommands(applicationId), {
auth,
body,
signal,
}) as Promise<RESTPutAPIApplicationCommandsResult>;
Expand All @@ -156,9 +161,10 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
guildId: Snowflake,
query: RESTGetAPIApplicationGuildCommandsQuery = {},
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.applicationGuildCommands(applicationId, guildId), {
auth,
query: makeURLSearchParams(query),
signal,
}) as Promise<RESTGetAPIApplicationGuildCommandsResult>;
Expand All @@ -177,9 +183,10 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
guildId: Snowflake,
body: RESTPostAPIApplicationGuildCommandsJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.post(Routes.applicationGuildCommands(applicationId, guildId), {
auth,
body,
signal,
}) as Promise<RESTPostAPIApplicationGuildCommandsResult>;
Expand All @@ -198,9 +205,10 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
guildId: Snowflake,
commandId: Snowflake,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.applicationGuildCommand(applicationId, guildId, commandId), {
auth,
signal,
}) as Promise<RESTGetAPIApplicationGuildCommandResult>;
}
Expand All @@ -220,9 +228,10 @@ export class ApplicationCommandsAPI {
guildId: Snowflake,
commandId: Snowflake,
body: RESTPatchAPIApplicationGuildCommandJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.patch(Routes.applicationGuildCommand(applicationId, guildId, commandId), {
auth,
body,
signal,
}) as Promise<RESTPatchAPIApplicationGuildCommandResult>;
Expand All @@ -241,9 +250,9 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
guildId: Snowflake,
commandId: Snowflake,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
await this.rest.delete(Routes.applicationGuildCommand(applicationId, guildId, commandId), { signal });
await this.rest.delete(Routes.applicationGuildCommand(applicationId, guildId, commandId), { auth, signal });
}

/**
Expand All @@ -259,9 +268,10 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
guildId: Snowflake,
body: RESTPutAPIApplicationGuildCommandsJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.put(Routes.applicationGuildCommands(applicationId, guildId), {
auth,
body,
signal,
}) as Promise<RESTPutAPIApplicationGuildCommandsResult>;
Expand All @@ -280,9 +290,10 @@ export class ApplicationCommandsAPI {
applicationId: Snowflake,
guildId: Snowflake,
commandId: Snowflake,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.applicationCommandPermissions(applicationId, guildId, commandId), {
auth,
signal,
}) as Promise<RESTGetAPIApplicationCommandPermissionsResult>;
}
Expand All @@ -298,9 +309,10 @@ export class ApplicationCommandsAPI {
public async getGuildCommandsPermissions(
applicationId: Snowflake,
guildId: Snowflake,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.guildApplicationCommandsPermissions(applicationId, guildId), {
auth,
signal,
}) as Promise<RESTGetAPIGuildApplicationCommandsPermissionsResult>;
}
Expand Down
34 changes: 25 additions & 9 deletions packages/core/src/api/applications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export class ApplicationsAPI {
* @see {@link https://discord.com/developers/docs/resources/application#get-current-application}
* @param options - The options for fetching the application
*/
public async getCurrent({ signal }: Pick<RequestData, 'signal'> = {}) {
return this.rest.get(Routes.currentApplication(), { signal }) as Promise<RESTGetCurrentApplicationResult>;
public async getCurrent({ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {}) {
return this.rest.get(Routes.currentApplication(), { auth, signal }) as Promise<RESTGetCurrentApplicationResult>;
}

/**
Expand All @@ -35,8 +35,12 @@ export class ApplicationsAPI {
* @param body - The new application data
* @param options - The options for editing the application
*/
public async editCurrent(body: RESTPatchCurrentApplicationJSONBody, { signal }: Pick<RequestData, 'signal'> = {}) {
public async editCurrent(
body: RESTPatchCurrentApplicationJSONBody,
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.patch(Routes.currentApplication(), {
auth,
body,
signal,
}) as Promise<RESTPatchCurrentApplicationResult>;
Expand All @@ -49,8 +53,9 @@ export class ApplicationsAPI {
* @param applicationId - The id of the application to fetch the emojis of
* @param options - The options for fetching the emojis
*/
public async getEmojis(applicationId: Snowflake, { signal }: Pick<RequestData, 'signal'> = {}) {
public async getEmojis(applicationId: Snowflake, { auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {}) {
return this.rest.get(Routes.applicationEmojis(applicationId), {
auth,
signal,
}) as Promise<RESTGetAPIApplicationEmojisResult>;
}
Expand All @@ -63,8 +68,13 @@ export class ApplicationsAPI {
* @param emojiId - The id of the emoji to fetch
* @param options - The options for fetching the emoji
*/
public async getEmoji(applicationId: Snowflake, emojiId: Snowflake, { signal }: Pick<RequestData, 'signal'> = {}) {
public async getEmoji(
applicationId: Snowflake,
emojiId: Snowflake,
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.get(Routes.applicationEmoji(applicationId, emojiId), {
auth,
signal,
}) as Promise<RESTGetAPIApplicationEmojiResult>;
}
Expand All @@ -80,9 +90,10 @@ export class ApplicationsAPI {
public async createEmoji(
applicationId: Snowflake,
body: RESTPostAPIApplicationEmojiJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.post(Routes.applicationEmojis(applicationId), {
auth,
body,
signal,
}) as Promise<RESTPostAPIApplicationEmojiResult>;
Expand All @@ -101,9 +112,10 @@ export class ApplicationsAPI {
applicationId: Snowflake,
emojiId: Snowflake,
body: RESTPatchAPIApplicationEmojiJSONBody,
{ signal }: Pick<RequestData, 'signal'> = {},
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
return this.rest.patch(Routes.applicationEmoji(applicationId, emojiId), {
auth,
body,
signal,
}) as Promise<RESTPatchAPIApplicationEmojiResult>;
Expand All @@ -117,7 +129,11 @@ export class ApplicationsAPI {
* @param emojiId - The id of the emoji to delete
* @param options - The options for deleting the emoji
*/
public async deleteEmoji(applicationId: Snowflake, emojiId: Snowflake, { signal }: Pick<RequestData, 'signal'> = {}) {
await this.rest.delete(Routes.applicationEmoji(applicationId, emojiId), { signal });
public async deleteEmoji(
applicationId: Snowflake,
emojiId: Snowflake,
{ auth, signal }: Pick<RequestData, 'auth' | 'signal'> = {},
) {
await this.rest.delete(Routes.applicationEmoji(applicationId, emojiId), { auth, signal });
}
}
Loading
Loading