Skip to content

types(interactions): fix overloads #10702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

imnaiyar
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Pointed out here: #10646 (comment)

Also added tests for each

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@imnaiyar imnaiyar requested a review from a team as a code owner January 13, 2025 09:42
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 7:15pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 7:15pm

@kodiakhq kodiakhq bot merged commit aa90f00 into discordjs:main Jan 18, 2025
7 checks passed
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.00%. Comparing base (052ed7f) to head (1447521).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10702      +/-   ##
==========================================
- Coverage   38.00%   38.00%   -0.01%     
==========================================
  Files         239      239              
  Lines       14894    14884      -10     
  Branches     1392     1385       -7     
==========================================
- Hits         5661     5657       -4     
+ Misses       9221     9216       -5     
+ Partials       12       11       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnaiyar imnaiyar deleted the interactions/overloads branch February 25, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants