Skip to content

types: fix recurrence rule types #10694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 4, 2025
Merged

types: fix recurrence rule types #10694

merged 9 commits into from
Feb 4, 2025

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Jan 5, 2025 •
edited by Jiralite
Loading

@vladfrangu vladfrangu requested a review from a team as a code owner January 5, 2025 21:38
@vladfrangu vladfrangu requested review from iCrawl, kyranet and SpaceEEC and removed request for a team January 5, 2025 21:38
@vercel Vercel
Copy link

vercel bot commented Jan 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 10:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 10:44pm

@Jiralite Jiralite added this to the discord.js 14.18 milestone Jan 5, 2025
@Jiralite Jiralite marked this pull request as draft January 12, 2025 20:30
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.51%. Comparing base (73c6bc2) to head (ca27e7c).
Report is 1 commits behind head on v14.

Additional details and impacted files 
@@           Coverage Diff           @@
##              v14   #10694   +/-   ##
=======================================
  Coverage   35.51%   35.51%           
=======================================
  Files         228      228           
  Lines       14317    14317           
  Branches     1255     1255           
=======================================
  Hits         5084     5084           
  Misses       9189     9189           
  Partials       44       44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladfrangu vladfrangu marked this pull request as ready for review February 3, 2025 22:37
@almeidx almeidx merged commit 193a5e9 into v14 Feb 4, 2025
8 checks passed
@almeidx almeidx deleted the backport/recurrence-type-fix branch February 4, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
backport packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js 14.18
Development

Successfully merging this pull request may close these issues.
5 participants
@vladfrangu @SpaceEEC @didinele @Jiralite @almeidx