refactor(Emoji)!: make imageURL() change extension dynamically #10613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
kyranet
previously requested changes
Dec 9, 2024
almeidx
approved these changes
Dec 21, 2024
almeidx
reviewed
Dec 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10613 +/- ##
=======================================
Coverage 38.00% 38.00%
=======================================
Files 239 239
Lines 14894 14894
Branches 1389 1390 +1
=======================================
Hits 5661 5661
Misses 9221 9221
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
idk if the docs/typings for |
almeidx
requested changes
Jan 10, 2025
almeidx
requested changes
Jan 11, 2025
SpaceEEC
approved these changes
Jan 12, 2025
almeidx
approved these changes
Jan 12, 2025
vladfrangu
approved these changes
Jan 13, 2025
almeidx
changed the title
Jiralite
previously requested changes
Jan 13, 2025
Jiralite
force-pushed
the
refactor-emoji
branch
from
96496c1 to
f4b4616
Compare
Co-authored-by: Aura <kyradiscord@gmail.com>
Co-authored-by: Almeida <github@almeidx.dev>
Jiralite
force-pushed
the
refactor-emoji
branch
from
f4b4616 to
d22e2c7
Compare
Jiralite
approved these changes
Jan 16, 2025
kodiakhq bot
added a commit
that referenced
this pull request
May 30, 2025
…le` (#10913) * types: remove unintended nullables from app and base guild emojis * feat: add ApplicationEmoji#available * types(BaseGuildEmoji): fix incorrect JSDoc type for BaseGuildEmoji#name Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com> * types(Emoji): switch from # to . for property deprecation links Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com> * fix: remove default nulls in app emoji constructor on non-nullables * types(Emoji): replace raw data type pre 78d512c * types(Emoji): switch to ImageURLOptions for imageURL() Re-applies changes from #10613 Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com> * types(Emoji): remove deprecated `url` props types and descriptions Added by mistake in PR that used to target v14 Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> * refactor(Emoji): wording and formatting changes to prop descriptions Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> * refactor(Emoji): missed wording and formatting change to prop descriptions Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> * fix(Emoji)!: remove non present Emoji#url from typings * fix(Emoji): re-apply emoji url types from 2c35084 --------- Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Image URLs of emojis now automatically return GIF or static extensions.
BREAKING CHANGE:
CDN#emoji()now has ananimatedrequired parameter.Please describe the changes this PR makes and why it should be merged:
I think it'd be better if
Emoji#imageURL()changes the extension dynamically as others...URL()functions.Status and versioning classification: