Skip to content

feat: add soundboard #10590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 25, 2025
Merged

feat: add soundboard #10590

merged 19 commits into from
Apr 25, 2025

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Adds soundboard for mainlib

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2025 4:06pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2025 4:06pm

@Jiralite

This comment has been minimized.

@sdanialraza sdanialraza force-pushed the feat/add-soundboard branch 2 times, most recently from f3031c1 to 55725d0 Compare February 8, 2025 14:26
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.55%. Comparing base (5a4de95) to head (77b2f36).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10590      +/-   ##
==========================================
- Coverage   44.42%   42.55%   -1.88%     
==========================================
  Files         260      251       -9     
  Lines       15325    14679     -646     
  Branches     1543     1445      -98     
==========================================
- Hits         6808     6246     -562     
+ Misses       8505     8421      -84     
  Partials       12       12              
Flag Coverage Δ
proxy 65.88% <ø> (ø)
rest 87.76% <100.00%> (+0.04%) ⬆️
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sdanialraza sdanialraza force-pushed the feat/add-soundboard branch 2 times, most recently from 830929a to 1e0fb55 Compare February 19, 2025 15:36
@sam51210

This comment was marked as off-topic.

@sdanialraza sdanialraza requested a review from vladfrangu March 9, 2025 23:24
@sdanialraza sdanialraza requested a review from Jiralite March 18, 2025 03:33
@sdanialraza sdanialraza dismissed stale reviews from vladfrangu and almeidx April 25, 2025 16:13

Resolved

@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Apr 25, 2025
@kodiakhq kodiakhq bot merged commit d81b4be into discordjs:main Apr 25, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 25, 2025
@sdanialraza sdanialraza deleted the feat/add-soundboard branch April 25, 2025 19:44
@sdanialraza sdanialraza added this to the discord.js 15.0.0 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants