-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat!: create forwards and add ChannelManager#createMessage()
#10559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing an implementation in send()
. Just like reply
is an option there, there should be a forward
option.
Although, now that both reply
and forward
is there, maybe both should be removed in favour of messageReference
so we don't have to keep adding new message reference types (and thus new properties).
a55e642
to
1156836
Compare
7ae23ed
to
6f08f65
Compare
6f08f65
to
afbbc7d
Compare
b636f5f
to
50ddc15
Compare
50ddc15
to
d45bd1c
Compare
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
0a29616
to
9525df0
Compare
9525df0
to
0029174
Compare
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
0029174
to
f7e480e
Compare
f7e480e
to
97a5cae
Compare
3691ef8
to
5bc0b35
Compare
5bc0b35
to
34893b7
Compare
ChannelManager#createMessage()
ChannelManager#createMessage()
Sorry if I'm blind, but I've just spent some time wondering why I can't see createMessage despite having the newest dependencies, and it being mentioned in the docs: https://discord.js.org/docs/packages/discord.js/main/ChannelManager:Class#createMessage Am I correct that this has not been shipped yet? May I suggest marking APIs that have not yet been released? Or adding a tag signifying which version they were introduced in? |
This PR was merged into the main branch meaning you need to ensure you're installing the dev version of discord.js ( |
Please describe the changes this PR makes and why it should be merged:
Adds a centralized spot where the creation of messages go through.
BREAKING CHANGE:
MessageCreateOptions
no longer acceptsforward
orreply
. UsemessageReference
instead.Status and versioning classification: