Skip to content

feat!: create forwards and add ChannelManager#createMessage() #10559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

TAEMBO
Copy link
Contributor

@TAEMBO TAEMBO commented Oct 16, 2024

Please describe the changes this PR makes and why it should be merged:
Adds a centralized spot where the creation of messages go through.

BREAKING CHANGE: MessageCreateOptions no longer accepts forward or reply. Use messageReference instead.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@TAEMBO TAEMBO requested a review from a team as a code owner October 16, 2024 06:38
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 9:20pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 9:20pm

@almostSouji

This comment was marked as outdated.

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing an implementation in send(). Just like reply is an option there, there should be a forward option.

Although, now that both reply and forward is there, maybe both should be removed in favour of messageReference so we don't have to keep adding new message reference types (and thus new properties).

@Jiralite Jiralite added this to the discord.js 14.17 milestone Oct 16, 2024
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from a55e642 to 1156836 Compare October 17, 2024 03:39
@TAEMBO TAEMBO requested a review from Jiralite October 17, 2024 03:44
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch 6 times, most recently from 7ae23ed to 6f08f65 Compare October 24, 2024 20:41
@TAEMBO TAEMBO changed the title feat: forwarding messages feat!: forwarding messages Oct 24, 2024
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from 6f08f65 to afbbc7d Compare November 29, 2024 17:55
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from b636f5f to 50ddc15 Compare February 7, 2025 20:49
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from 50ddc15 to d45bd1c Compare February 9, 2025 21:55
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from 0a29616 to 9525df0 Compare February 15, 2025 02:51
@TAEMBO TAEMBO requested a review from almeidx February 15, 2025 02:52
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from 9525df0 to 0029174 Compare February 15, 2025 03:19
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from 0029174 to f7e480e Compare February 19, 2025 23:30
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from f7e480e to 97a5cae Compare February 19, 2025 23:30
@TAEMBO TAEMBO requested a review from almeidx February 19, 2025 23:32
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch 4 times, most recently from 3691ef8 to 5bc0b35 Compare February 20, 2025 01:14
@TAEMBO TAEMBO force-pushed the feat/forwarding-messages branch from 5bc0b35 to 34893b7 Compare February 20, 2025 21:20
@TAEMBO TAEMBO requested a review from almeidx February 20, 2025 21:22
@almeidx almeidx changed the title feat!: add ChannelManager#createMessage() feat!: create forwards and add ChannelManager#createMessage() Feb 20, 2025
@almeidx almeidx merged commit 0e7bdb0 into discordjs:main Feb 20, 2025
9 checks passed
@TAEMBO TAEMBO deleted the feat/forwarding-messages branch February 20, 2025 22:11
@nukeop
Copy link

nukeop commented Feb 27, 2025

Sorry if I'm blind, but I've just spent some time wondering why I can't see createMessage despite having the newest dependencies, and it being mentioned in the docs: https://discord.js.org/docs/packages/discord.js/main/ChannelManager:Class#createMessage

Am I correct that this has not been shipped yet?

May I suggest marking APIs that have not yet been released? Or adding a tag signifying which version they were introduced in?

@TAEMBO
Copy link
Contributor Author

TAEMBO commented Feb 27, 2025

This PR was merged into the main branch meaning you need to ensure you're installing the dev version of discord.js (npm i discord.js@dev) in order to use features not yet in a stable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants