ci: skip coverage upload on missing files #10453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The Test step only runs for the packages that were modified (either compared to the previous commit, in the case of a merge, or in the entire pull request), which means that the coverage upload fails for the other packages, where the tests weren't ran
To prevent the fails and consequently speed up the Tests workflow, skipped the coverage upload for packages that don't have the coverage result file.
discord.js/.github/workflows/tests.yml
Lines 38 to 44 in bf83db9
Example of upload failure:
https://github.com/discordjs/discord.js/actions/runs/10469755109/job/28993460857#step:13:64
Status and versioning classification: