Skip to content

ci: skip coverage upload on missing files #10453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 20, 2024

Please describe the changes this PR makes and why it should be merged:
The Test step only runs for the packages that were modified (either compared to the previous commit, in the case of a merge, or in the entire pull request), which means that the coverage upload fails for the other packages, where the tests weren't ran

To prevent the fails and consequently speed up the Tests workflow, skipped the coverage upload for packages that don't have the coverage result file.

- name: Tests (PR)
if: ${{ github.event_name != 'push' }}
run: pnpm exec turbo run test --filter="...[origin/${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref || 'main' }}]" --concurrency=4
- name: Tests (Push)
if: ${{ github.event_name == 'push' }}
run: pnpm exec turbo run test --filter="...[HEAD^1]" --concurrency=4

Example of upload failure:
https://github.com/discordjs/discord.js/actions/runs/10469755109/job/28993460857#step:13:64

Status and versioning classification:

@almeidx almeidx requested a review from a team as a code owner August 20, 2024 10:40
@almeidx almeidx requested review from ckohen, iCrawl and Jiralite August 20, 2024 10:40
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 11:52am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 11:52am

@almeidx almeidx added the ci label Aug 20, 2024
@kodiakhq kodiakhq bot merged commit ec9080b into main Aug 22, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the ci/skip-coverage-upload branch August 22, 2024 11:55
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.90%. Comparing base (bba0e72) to head (e1515ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10453      +/-   ##
==========================================
- Coverage   50.91%   50.90%   -0.01%     
==========================================
  Files         228      228              
  Lines       20750    20746       -4     
  Branches     1258     1256       -2     
==========================================
- Hits        10565    10561       -4     
  Misses      10141    10141              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nyapat pushed a commit to nyapat/discord.js that referenced this pull request Sep 9, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants