feat(voice)!: add new encryption methods, remove old methods #10451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Qjuh
requested changes
Aug 19, 2024
nyapat
force-pushed
the
feat/voice-encryption
branch
2 times, most recently
from
47606c3 to
4879a69
Compare
vladfrangu
reviewed
Aug 22, 2024
|
when #10472 is ready i will update tests for this (tweetnacl is being swapped out for stablelib & jest utterly hates it) |
nyapat
force-pushed
the
feat/voice-encryption
branch
from
52469d5 to
846b594
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10451 +/- ##
==========================================
- Coverage 38.17% 38.14% -0.03%
==========================================
Files 239 239
Lines 15495 15578 +83
Branches 1369 1376 +7
==========================================
+ Hits 5915 5943 +28
- Misses 9565 9620 +55
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nyapat
changed the title
vladfrangu
requested changes
Oct 7, 2024
SpaceEEC
requested changes
Nov 17, 2024
vladfrangu
approved these changes
Nov 17, 2024
SpaceEEC
approved these changes
Nov 17, 2024
nyapat
commented
Nov 17, 2024
iCrawl
approved these changes
Nov 17, 2024
kyranet
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Added the new encryption methods that Discord will enforce for all voice users in November. Since the older methods are being deprecated entirely, I am removing them as well. Because tweetnacl does not support the cipher methods necessary for xchacha, I have removed it and replaced it with @stablelib/xchacha20poly1305 (aes256gcm does not require anything other than node:crypto, so that could theoretically be the only one needed if the vc always requested that)
Testing has been added for the encryption methods aswell, and I have changed some older tests to properly remove the RTP header based on the original encrypted data.
Status and versioning classification: