refactor(website): search index name of members includes class now #10415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10415 +/- ##
=======================================
Coverage 50.79% 50.79%
=======================================
Files 228 228
Lines 20689 20689
Branches 1258 1258
=======================================
Hits 10508 10508
Misses 10137 10137
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vladfrangu
approved these changes
Jul 31, 2024
ckohen
approved these changes
Aug 2, 2024
almeidx
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Previously the search index for e.g.
GuildMember#guildhad justguildas name for the entry and only the path it links to and maybe the description told you what class it belongs to.With this small change the name now includes the Classname too and also distinguishes methods from properties. I.e.
fetchis nowGuildMember.fetch().Status and versioning classification: