Skip to content

chore(deps): match requested tslib version with other @discordjs packages #10373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kevinlul
Copy link

@kevinlul kevinlul commented Jul 2, 2024

Please describe the changes this PR makes and why it should be merged:

@discordjs/builders, @discordjs/rest, @discordjs/ws, and possibly others request a slightly different version of tslib than the main package. This synchronizes them so two different versions of tslib are not installed Discord.js (2.6.3 was released last month).

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@kevinlul kevinlul requested a review from a team as a code owner July 2, 2024 01:24
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 28, 2024 1:38pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 28, 2024 1:38pm

@vladfrangu vladfrangu changed the title Match requested tslib version with other @discordjs packages chore(deps): match requested tslib version with other @discordjs packages Jul 2, 2024
@vladfrangu
Copy link
Member

Can you run pnpm i too, to update the lockfile?

@kevinlul
Copy link
Author

kevinlul commented Jul 3, 2024

That seems to create a lot of unrelated changes in pnpm-lock.yaml. Is that correct? I expected only tslib-related entries would change.

@almeidx
Copy link
Member

almeidx commented Aug 23, 2024

Superseded by #10457

@almeidx almeidx closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants